fix(player): guard against undefined button from createPlayerButton#4152
Open
baima365-web wants to merge 1 commit into
Open
fix(player): guard against undefined button from createPlayerButton#4152baima365-web wants to merge 1 commit into
baima365-web wants to merge 1 commit into
Conversation
When YouTube's playback speed button hasn't been added to the DOM yet, createPlayerButton returns undefined. Calling .onclick/.addEventListener on undefined throws TypeError and breaks subsequent button initialization. Fix: early return if button is falsy after createPlayerButton returns. Closes code-charity#4114
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When YouTube's playback speed button hasn't been added to the DOM yet,
createPlayerButton()returnsundefinedbecauseplayer_left_controlsorplayer_right_controlsdon't exist. Callingonclick/addEventListeneronundefinedthrows aTypeErrorand breaks subsequent button initialization (repeat, screenshot, rotate, etc.).Error:
Uncaught TypeError: can't access property "addEventListener", button is undefinedThis manifests as ImproveTube's extra buttons not appearing until the page is manually refreshed.
Fix
Add an early return check
if (!button) return;aftercreatePlayerButton()in bothplayerPlaybackSpeedButtonfunction definitions.Changes
js&css/web-accessible/www.youtube.com/player.js: Added null guard in bothplayerPlaybackSpeedButtonfunction definitions (lines 701 and 1100)